Repository navigation
fix(e2e-harness): exit tui-snapshots with the host's exit code - #1341
Merged
Merged
Conversation
TuiCapture.exited resolved without the child's exit code, and tui-snapshots always exited 0, so a host crash or an aborted run still passed the sweep. `exited` now resolves with the exit code, or 128 + signal when a signal ended the host, and tui-snapshots exits with it. Part of #1333 Generated-By: PostHog Desktop Task-Id: d14e92bb-6ee1-49b5-8502-39cb80079589
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Test against a Context Mill branch:
Add Results will be posted here when complete. |
gewenyu99
marked this pull request as ready for review
September 24, 2026 22:35
johncwaters
approved these changes
Oct 2, 2026
johncwaters
left a comment
Contributor
There was a problem hiding this comment.
Note
Automated review. Not written by a human.
Reviewed: TuiCapture.exited now resolves with the host's exit code (128 + signal on signal death), and tui-snapshots exits with it. The only consumer is updated, the host's success path exits 0, and the new test covers exit 0, exit 3 and SIGTERM. No issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
tui-snapshotsalways exits 0.TuiCapture.exitedresolves without the host's exit code, so a host crash or an aborted run still passes the sweep. The workbench pass condition includesrun.status === 0, so it never sees a host failure.Part of #1333 (the exit-code half of item 5).
Changes
TuiCapture.exited. Resolves with the exit code, or 128 + signal.tui-snapshots. Exits with that code and prints it on the done line.Nothing flows here.
tui-capture.tspasses node-pty's exit code through, and the driver uses it.This covers host crashes and
wizardAbortexits. A run that completes with a missing report still exits 0. That check waits on picking one report channel in #1332.Test plan
tui-capture.test.tsspawns a child in a PTY that exits 0, exits 3, or kills itself with SIGTERM, and expects 0, 3 and 143. It failed on main and passes with the fix.pnpm typecheck,pnpm lint(0 errors) andpnpm test(200 files, 3351 tests) pass.LLM context
Written by Claude Code while triaging the real-TUI sweep issues.
Created with PostHog Desktop